Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-2836] chore: workspace draft and project issue local db mutation #6180

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[WEB-2836] chore: workspace draft and project issue local db mutation #6180

merged 1 commit into from
Dec 10, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Dec 10, 2024 •
edited by coderabbitai bot
Loading

Description

This PR includes enhancements for the local database, focusing on workspace drafts and project intake issue mutations.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

References

[WEB-2836]

Summary by CodeRabbit

  • Bug Fixes

    • Improved data persistence logic for inbox and workspace draft issues.
    • Enhanced error handling during issue updates and state restoration.

  • Chores

    • Refined method implementations for better data structure management without altering existing functionalities.

@anmolsinghbhatia anmolsinghbhatia added this to the 0.25 milestone Dec 10, 2024
@anmolsinghbhatia anmolsinghbhatia self-assigned this Dec 10, 2024
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024 •
edited
Loading

Walkthrough

The changes involve modifications to the InboxIssueStore and WorkspaceDraftIssues classes, specifically focusing on how issues are persisted to the database. In InboxIssueStore, the updateInboxIssueStatus method now merges the current issue with the incoming issue data using the spread operator. Similarly, in WorkspaceDraftIssues, the moveIssue method has been adjusted to combine the payload with the response before persisting. Error handling remains consistent, ensuring stability during asynchronous operations.

Changes

File Path Change Summary
web/core/store/inbox/inbox-issue.store.ts Modified updateInboxIssueStatus to merge this.issue with inboxIssue.issue using spread.
web/core/store/issue/workspace-draft/issue.store.ts Changed moveIssue to combine payload and response when calling addIssueToPersistanceLayer.

Possibly related PRs

Suggested reviewers

  • sriramveeraghanta
  • SatishGandham
  • rahulramesha

🐰 In the meadow, where issues bloom,
A spread of data makes room!
With persistence in our sights,
We hop along through coding nights.
Merging changes, oh what fun,
Together, we’ve just begun! 🌼

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 205395e and a2cfd91.

📒 Files selected for processing (2)
  • web/core/store/inbox/inbox-issue.store.ts (1 hunks)
  • web/core/store/issue/workspace-draft/issue.store.ts (1 hunks)
🔇 Additional comments (2)
web/core/store/inbox/inbox-issue.store.ts (1)

101-101: LGTM! Improved data persistence by preserving existing issue data.

The spread operator usage ensures that existing issue data is preserved while being updated with new values from the inbox issue. This prevents potential data loss during persistence.

web/core/store/issue/workspace-draft/issue.store.ts (1)

355-355: LGTM! Consistent data persistence pattern with InboxIssueStore.

The spread operator usage ensures that draft-specific data from the payload is preserved while being updated with the response data. This change aligns with the pattern used in InboxIssueStore, maintaining consistency across the codebase.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 merged commit 216a69f into preview Dec 10, 2024
12 of 14 checks passed
@pushya22 pushya22 deleted the chore-workspace-draft-and-inbox-issue-local-db-improvement branch December 10, 2024 13:42
@coderabbitai coderabbitai bot mentioned this pull request Dec 10, 2024
Merged
6 tasks
@sriramveeraghanta sriramveeraghanta modified the milestones: 0.25, v0.24.1 Dec 10, 2024
This was referenced Dec 11, 2024
Closed
Merged
nishantPFM pushed a commit to Pocket-Fm/plane that referenced this pull request Dec 12, 2024
@anmolsinghbhatia @nishantPFM
chore: workspace draft and inbox issue local db mutation (makeplane#6180
54e9a44 
)
@coderabbitai coderabbitai bot mentioned this pull request Dec 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SatishGandham SatishGandham SatishGandham approved these changes

@sriramveeraghanta sriramveeraghanta Awaiting requested review from sriramveeraghanta

Assignees

@anmolsinghbhatia anmolsinghbhatia

Labels
🧹chore 🌐frontend
Projects
None yet
Milestone
v0.24.1
Development

Successfully merging this pull request may close these issues.
4 participants
@anmolsinghbhatia @SatishGandham @sriramveeraghanta @pushya22